Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FE] fix: S3 이미지 업로드 수정 #582

Merged
merged 3 commits into from
Sep 8, 2023
Merged

[FE] fix: S3 이미지 업로드 수정 #582

merged 3 commits into from
Sep 8, 2023

Conversation

Leejin-Yang
Copy link
Collaborator

Issue

✨ 구현한 기능

  • S3클라이언트에 region 추가

📢 논의하고 싶은 내용

x

🎸 기타

  • 생각해보니 젠킨스에 환경변수 설정을 안했네요 ㅎㅎ..

⏰ 일정

  • 추정 시간 :
  • 걸린 시간 :

@Leejin-Yang Leejin-Yang self-assigned this Sep 8, 2023
hae-on
hae-on approved these changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@hae-on hae-on left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 남긴 거 궁금함니다

frontend/src/hooks/common/useImageUploader.ts
await client.send(image);
setPreviewImage(URL.createObjectURL(imageFile));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

순서를 바꾼 이유는 무엇인가요?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

업로드 실패시 미리보기도 안나오게 했습니다!

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Unit Test Results

2 tests   2 ✔️  6s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 6c616a9.

@Leejin-Yang Leejin-Yang merged commit 461a944 into develop Sep 8, 2023
@Leejin-Yang Leejin-Yang deleted the fix/issue-581 branch September 8, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hae-on hae-on hae-on approved these changes

@xodms0309 xodms0309 xodms0309 approved these changes

Assignees

@Leejin-Yang Leejin-Yang

Labels
🐛 Bug 🔑 FE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FE] S3 업로드 에러
3 participants
@Leejin-Yang @xodms0309 @hae-on